Skip to content

[ResponseOps][Connectors] Zod lazy schemas @kbn/connector-specs#265482

Merged
georgianaonoleata1904 merged 13 commits into
elastic:mainfrom
georgianaonoleata1904:wrap-zod-schemas-connector-specs
May 6, 2026
Merged

[ResponseOps][Connectors] Zod lazy schemas @kbn/connector-specs#265482
georgianaonoleata1904 merged 13 commits into
elastic:mainfrom
georgianaonoleata1904:wrap-zod-schemas-connector-specs

Conversation

@georgianaonoleata1904
Copy link
Copy Markdown
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Apr 24, 2026 •
edited
Loading

Closes #264180

Summary

Wraps all Zod schema definitions in @kbn/connector-specs with lazySchema()

@georgianaonoleata1904 georgianaonoleata1904 changed the title [ResponseOps][Connectors] Zod lazy schemas @kbn/connector-schemas [ResponseOps][Connectors] Zod lazy schemas @kbn/connector-specs Apr 24, 2026
@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Apr 24, 2026
@georgianaonoleata1904 georgianaonoleata1904 added backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.5.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 24, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 24, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-observability_complete - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-serverless-security_complete - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show root-level property suggestions on empty lines
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show step type autocompletion suggestions
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed
  • [job] [logs] affected Scout: [ platform / workflows_management ] plugin / local-stateful-classic - Sanity tests for workflows - should show validation errors for invalid workflow YAML and clear them when fixed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 1.8MB 1.8MB +7.9KB
workflowsManagement 2.3MB 2.3MB +6.5KB
total +14.4KB

History

cc @georgianaonoleata1904

@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review April 27, 2026 05:03
@georgianaonoleata1904 georgianaonoleata1904 requested review from a team as code owners April 27, 2026 05:03
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 27, 2026

Pinging @elastic/response-ops (Team:ResponseOps)

lorenabalan
lorenabalan approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on EARS auth type and on connectors owned by our team (search-agent-builder-1). Should we add a note to the skill src/platform/packages/shared/kbn-connector-specs/.claude/skills/create-connector/SKILL.md to make sure new connectors follow the same pattern?

@botelastic botelastic Bot added the Team:One Workflow Team label for One Workflow (Workflow automation) label Apr 27, 2026
yngrdyn
yngrdyn approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgianaonoleata1904 georgianaonoleata1904 enabled auto-merge (squash) May 6, 2026 08:06
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 1.8MB 1.8MB +7.8KB
workflowsManagement 2.3MB 2.3MB +6.4KB
total +14.2KB

History

cc @georgianaonoleata1904

@georgianaonoleata1904 georgianaonoleata1904 merged commit 3113842 into elastic:main May 6, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nomagick nomagick nomagick approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@lorenabalan lorenabalan lorenabalan approved these changes

@jcger jcger jcger approved these changes

Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:One Workflow Team label for One Workflow (Workflow automation) Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Zod lazy schemas @kbn/connector-specs

7 participants

@georgianaonoleata1904 @elasticmachine @kibanamachine @nomagick @yngrdyn @lorenabalan @jcger